Skip to content

chore: use fmt.Errorf instead of errors.Wrap #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use fmt.Errorf instead of errors.Wrap #146

wants to merge 1 commit into from

Conversation

flaneur2020
Copy link
Member

it seems that errors.Wrap was introduced before fmt.Errorf() in the stdlib was introduced.

the current error message is like:

context canceled: DoRequestFailed

the convention is becoming to put the root cause part into the right side, for example:

do request failed: context canceled

@forsaken628
Copy link
Contributor

github.com/pkg/errors provides stack information that will make debugging easier, otherwise we need to carefully handle the error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaneur2020 @forsaken628